Add Fing integration #126058
Add Fing integration #126058
Conversation
…-integration into fing-integration
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
| """Fetch data from Fing Agent.""" | ||
| try: | ||
| return await self._fing_fetcher.fetch_data() | ||
| except Exception as err: |
There was a problem hiding this comment.
Oh we should indeed raise UpdateFailed, but we should not catch bare exceptions. We want to be more specific on what we catch.
Please double check the DataUpdateCoordinator class, because I believe it already catches issues from httpx (I know it catches aiohttp exceptions, but I am not sure if httpx also is catched). We should catch any extra exceptions then
|
You need to include a |
Proposed change
Adding support for Fing integration (https://www.fing.com/).
This integration allow HA to retrieve device information through the local API exposed by Fing agents (Fing Agent, Fingbox, Fing Desktop).
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: