Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address yale review comments part 2 #124887

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Address yale review comments part 2 #124887

merged 3 commits into from
Aug 30, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 29, 2024

Proposed change

Address yale review comments part 2 from #124677

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@bdraco bdraco added this to the 2024.9.0 milestone Aug 29, 2024
@bdraco
Copy link
Member Author

bdraco commented Aug 29, 2024

Tagged to avoid future conflicts

@bdraco bdraco marked this pull request as ready for review August 29, 2024 22:27
@balloob balloob merged commit df60e59 into dev Aug 30, 2024
26 checks passed
@balloob balloob deleted the yale_review_follow_pt2 branch August 30, 2024 07:37
@bdraco
Copy link
Member Author

bdraco commented Aug 30, 2024

thanks

bramkragten pushed a commit that referenced this pull request Aug 30, 2024
* Remove some unneeded block till done

* Additional state check cleanups and snapshots

* Use more snapshots in yale tests
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants