-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump nice-go
to 0.3.8
#124872
Merged
Merged
Bump nice-go
to 0.3.8
#124872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
dependency
integration: nice_go
small-pr
PRs with less than 30 lines.
by-code-owner
Quality Scale: No score
labels
Aug 29, 2024
joostlek
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we loosen the pin on tenacity? I think it's now only matching 8.5.0, which will be a pain once we ever need to update
CI just needs a re-run. Cache isn't up to date |
joostlek
approved these changes
Aug 30, 2024
bramkragten
pushed a commit
that referenced
this pull request
Aug 30, 2024
synesthesiam
pushed a commit
that referenced
this pull request
Aug 30, 2024
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cherry-picked
cla-signed
dependency
integration: nice_go
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Bumps
nice-go
to 0.3.7. Switches totenacity
for retrying.Greatly reduces re-connection time:
https://github.com/IceBotYT/nice-go/releases/tag/0.3.6
https://github.com/IceBotYT/nice-go/releases/tag/0.3.7
https://github.com/IceBotYT/nice-go/releases/tag/0.3.8
IceBotYT/nice-go@0.3.5...0.3.8
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: