Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nice-go to 0.3.8 #124872

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Bump nice-go to 0.3.8 #124872

merged 3 commits into from
Aug 30, 2024

Conversation

IceBotYT
Copy link
Contributor

@IceBotYT IceBotYT commented Aug 29, 2024

Proposed change

Bumps nice-go to 0.3.7. Switches to tenacity for retrying.
Greatly reduces re-connection time:

image

https://github.com/IceBotYT/nice-go/releases/tag/0.3.6
https://github.com/IceBotYT/nice-go/releases/tag/0.3.7
https://github.com/IceBotYT/nice-go/releases/tag/0.3.8
IceBotYT/nice-go@0.3.5...0.3.8

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we loosen the pin on tenacity? I think it's now only matching 8.5.0, which will be a pain once we ever need to update

@IceBotYT IceBotYT changed the title Bump nice-go to 0.3.7 Bump nice-go to 0.3.8 Aug 30, 2024
@IceBotYT
Copy link
Contributor Author

CI just needs a re-run. Cache isn't up to date

@joostlek joostlek closed this Aug 30, 2024
@joostlek joostlek reopened this Aug 30, 2024
@joostlek joostlek added this to the 2024.9.0 milestone Aug 30, 2024
@joostlek joostlek merged commit 28c24e5 into home-assistant:dev Aug 30, 2024
58 of 59 checks passed
bramkragten pushed a commit that referenced this pull request Aug 30, 2024
* Bump nice-go to 0.3.6

* Bump to 0.3.7

* Bump to 0.3.8
synesthesiam pushed a commit that referenced this pull request Aug 30, 2024
* Bump nice-go to 0.3.6

* Bump to 0.3.7

* Bump to 0.3.8
@IceBotYT IceBotYT deleted the nice-go-0.3.6 branch August 31, 2024 13:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants