-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constrain dacite to at least 1.7.0 #105709
Conversation
Hey there @humbertogontijo, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Just found this PR and i think that it might solve this issue i opened,#106445 |
We had a similar problem with Is there another reason that you pin to version |
You say had, did those integrations solve it differently?
Nope - fair enough, I have changed to 1.7.0 |
I pinned |
Interesting, that never worked for me, it still ended up downloading the wrong version for some users. |
No no, it was never 100% sure. A custom component can force its version of the package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Lash-L
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Breaking change
Proposed change
Dacite is a package that converts dictionaries to dataclasses with complex types. It is used in our library to be able to take dictionaries that are multilevel nested and turn them into classes with multilevel nesting or enums. It's rather helpful.
The issue is that some custom integrations (such as hacs-govee) are pinning dacite to a lower version. hacs-govee has since made the change, but some users are not updating it or their issue is being caused by another integration.
The problem randomly started in September, before then, the correct version was always installed. I have tried everything I could think of to fix this problem.
If someone has an alternative fix, I am more than happy to hear it, but I have asked around a few times and no one has had any ideas. I am closing out issues for it rather frequently so I thought I would try this and see if it helped at all.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: