Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restoring custom fields in service button widget #3813

Merged

Conversation

jpelgrom
Copy link
Member

Summary

Fix #3812 and two other bugs found while working on it:

  • Fix RecyclerView not setting fields to empty when no value is present, potentially showing input from other recycled fields if the field doesn't have any value.
  • Fix adding a new custom field destroying any input currently held in the views by using a specific insertion method instead of all changed, which will reset the values.

Screenshots

n/a

Link to pull request in Documentation repository

n/a

Any other notes

 - When reading service data from the database, make sure to also add custom fields.
 - Fix RecyclerView not setting fields to empty when no value is present, potentially showing input from other recycled fields if the field doesn't have any value.
 - Fix adding a new custom field destroying any input currently held in the views by using a specific insertion method instead of all changed, which will reset the values.
@JBassett JBassett merged commit cad1bfa into home-assistant:master Aug 24, 2023
@jpelgrom jpelgrom deleted the fix-service-button-custom-fields branch August 24, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added fields on Service Button widget are lost if widget is re-edited
3 participants