Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fields on Service Button widget are lost if widget is re-edited #3812

Closed
glynaunac opened this issue Aug 23, 2023 · 5 comments · Fixed by #3813
Closed

Added fields on Service Button widget are lost if widget is re-edited #3812

glynaunac opened this issue Aug 23, 2023 · 5 comments · Fixed by #3813
Labels
bug Something isn't working widget

Comments

@glynaunac
Copy link

glynaunac commented Aug 23, 2023

Home Assistant Android app version(s): 2023.8.2-full

Android version(s): 11

Device model(s): Moto g9 play

Home Assistant version: 2023.8.3

**Last working Home Assistant release (if known):**Latest

Description of problem, include YAML if issue is related to notifications:

If you add fields to a service button widget and then go back into the setup for the widget after saving, the added fields are not displayed.

If you then exit the widget settings page without saving, the fields and values are retained and any actions work as expected.

If, however, you click 'Update Widget', even without making any changes, the fields and values are removed.

Companion App Logs:

@glynaunac glynaunac added the bug Something isn't working label Aug 23, 2023
@dshokouhi
Copy link
Member

Can you please post your app version?

I thought this was fixed in #3514

@dshokouhi dshokouhi added question Further information is requested widget labels Aug 23, 2023
@glynaunac
Copy link
Author

Sorry, the app version is 2023.8.2-full.

@jpelgrom
Copy link
Member

I thought this was fixed in #3514

Looks like this issue relates to custom/added fields, normal fields exposed by the service work correctly, so I think this has been broken for quite some time.

@jpelgrom jpelgrom removed the question Further information is requested label Aug 23, 2023
@glynaunac
Copy link
Author

Yes, I am using added fields to pass parameters to a script.

@jpelgrom
Copy link
Member

Fix submitted.

@dshokouhi I spoke too soon: it does look like this wasn't handled properly in the mentioned PR, the widget code was simplified with multiserver and no longer accounted for custom fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working widget
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants