Add support for raw soil moisture values #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvizeli
approved these changes
Feb 5, 2024
pantonvich
added a commit
to pantonvich/aioecowitt
that referenced
this pull request
Feb 5, 2024
* Bump release-drafter/release-drafter from 5.25.0 to 6.0.0 (home-assistant-libs#146) Bumps [release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) from 5.25.0 to 6.0.0. - [Release notes](https://github.com/release-drafter/release-drafter/releases) - [Commits](release-drafter/release-drafter@v5.25.0...v6.0.0) --- updated-dependencies: - dependency-name: release-drafter/release-drafter dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add support for raw soil moisture values (home-assistant-libs#145) * Push version to 2024.2.0 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dcmeglio <[email protected]> Co-authored-by: Pascal Vizeli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #127
That PR ignores soil moisture raw values, but what if someone wants access to the values? Why discard them? This instead adds support for them. This would help resolve Home-Assistant issue home-assistant/core#102738
I spoke with Ecowitt directly and the soilad values are a raw analog to digital conversion. This value gets converted to the percentage using the formula
Soil_Moisture = (Now_AD - 0%AD) * 100% / (100% AD - 0%AD )so if someone wants the raw value, this will now be exposed.