Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore SOILADx calibration sensor values #127

Closed
wants to merge 1 commit into from

Conversation

sam-ward
Copy link

Add additional sensor value mappings to ignore the soiladx soil moisture sensor calibration values being sent since the v1.7.7 firmware update.

Add additional sensor value mappings to ignore the soiladx soil moisture sensor calibration values being sent since the v1.7.7 firmware update.
@sam-ward
Copy link
Author

This should resolve home-assistant/core#102738

Copy link
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ignore?

@sam-ward
Copy link
Author

Probably a bad assumption on my part, but I didn't see the point of always capturing what is essentially a static value. I guess it could be exposed as a diagnostic value if there's merit in it (assuming we can work out the scaling between the raw value and what the app shows).

@pvizeli
Copy link
Member

pvizeli commented Feb 5, 2024

Close in flavor of #145

@pvizeli pvizeli closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants