-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve piplite.install time for Panelite notebooks #4388
Conversation
Hi @philippjfr. This is how I would minimize the I will determine and test the list of dependencies for each notebook manually. If there is an automated way to test this, then please let me know. I chose not to add the specific |
According to jupyterlite/jupyterlite#379 (comment) it should now be possible to provide a direct link to a specific notebook in Jupyterlite. I.e. it should be possible to setup an automated test using Playright that each notebook can run. For example this link works https://panelite.holoviz.org/lab/index.html?path=reference/panes/DataFrame.ipynb |
Codecov Report
@@ Coverage Diff @@
## main #4388 +/- ##
==========================================
- Coverage 82.32% 79.11% -3.22%
==========================================
Files 243 243
Lines 35579 35579
==========================================
- Hits 29292 28147 -1145
- Misses 6287 7432 +1145
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assets (needed due to CORS issues with existing links)panel-014.jpg panel-013.jpg portfolio-analysis.mp4 ezgif.com-gif-maker.9.mp4dummy.pdf sample.pdf |
a697a09
to
090fef4
Compare
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge this as-is for now. Might spend some time cleaning this up further. Specifically we do have pn.io.mime_render.find_imports
which tries to automatically extract required imports from source code.
Closes #4209
Closed in this PR
Worked around in this PR
Main Panel Issues
Other Panel Issues
Other Issues
path
query argument to notebook in subfolder breaks Jupyterlite. jupyterlite/jupyterlite#973