Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal.ipynb not working in Panelite: Cannot run subprocesses #4407

Open
MarcSkovMadsen opened this issue Feb 5, 2023 · 4 comments
Open
Labels
type: bug Something isn't correct or isn't working
Milestone

Comments

@MarcSkovMadsen
Copy link
Collaborator

Panelite=0.14.3

I'm trying the notebook reference/widgets/Terminal.ipynb. I can see that the command terminal.subprocess.run fails with errors. This is probably expected and not something that can be fixed.

image

ImportError: cannot import name 'tcgetattr' from 'tty' (/lib/python3.10/tty.py)

image

 File "/lib/python3.10/site-packages/panel/widgets/terminal.py", line 144, in _set_winsize
    fcntl.ioctl(self._fd, termios.TIOCSWINSZ, winsize)
AttributeError: module 'fcntl' has no attribute 'ioctl'
@MarcSkovMadsen MarcSkovMadsen added the type: bug Something isn't correct or isn't working label Feb 5, 2023
@MarcSkovMadsen MarcSkovMadsen added this to the Wishlist milestone Feb 5, 2023
@philippjfr
Copy link
Member

This will likely never work. Not sure what you suggest, I'd probably just not include the reference example on panelite.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Feb 6, 2023

My thoughts is that with the work I do we know about issues in notebooks. So we can include a new first Markdown cell explaining that

For example the HoloViews reference notebook does not work either. But here the issue will probably be fixed one day.

Parts of the Terminal notebook is useful - also on Panelite. And its the only documentation we have.

I believe that as soon as we have cleaned up biggest Panelite issues we should link to Panelite instead of Binder. It would be a huge improvement.

@philippjfr
Copy link
Member

Agree with that plan of action but for this particular instance I would not open an issue because it's something that can't be fixed.

@philippjfr
Copy link
Member

i.e. the message should just say subprocesses not supported in a browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

No branches or pull requests

2 participants