Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes subplots=True for geo=True and with by-statement #761

Merged
merged 5 commits into from
Mar 16, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 30, 2022

The second part (2/2) of the fix for https://discourse.holoviz.org/t/small-multiples-aka-facetted-plots/3760/2

This will make it possible to run (after holoviz/holoviews#5325 is merged):

import geopandas as gpd
import hvplot.pandas

countries = gpd.read_file(gpd.datasets.get_path('naturalearth_lowres'))
countries.hvplot(geo=True, by="continent", subplots=True)

Before fix (with holoviz/holoviews#5325):
image

After fix:
image

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@maximlt maximlt added the type: upstream Anything that requires work outside hvPlot label Oct 11, 2022
@maximlt
Copy link
Member

maximlt commented Mar 16, 2023

Added an xfail test in f30077c that was passing with holoviz/holoviews#5325.

We've discussed about holoviz/holoviews#5325 recently and the fix on the HoloViews side is likely going to be different. But that doesn't really matter for hvPlot, I think. @hoxbro do you see any reason not to merge this?

@hoxbro
Copy link
Member Author

hoxbro commented Mar 16, 2023

Nope. I would love to see this merged.

@maximlt
Copy link
Member

maximlt commented Mar 16, 2023

Great thanks, merging then.

@maximlt maximlt merged commit cbab46c into holoviz:main Mar 16, 2023
@hoxbro hoxbro deleted the fix_subplots_geo branch March 16, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: upstream Anything that requires work outside hvPlot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants