-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding geodataframe to DataConversion #5325
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5325 +/- ##
==========================================
- Coverage 88.32% 88.29% -0.04%
==========================================
Files 302 302
Lines 62579 62542 -37
==========================================
- Hits 55272 55220 -52
- Misses 7307 7322 +15
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'm also unsure about supporting |
@philippjfr we had a discussion about this a couple of weeks ago, can you remember what you decided about this? I remember there was a suggestion to move the interface from GeoViews to HoloViews. It would be nice if we could summarize the plan so that someone could pick up that work. |
Other than a minor renaming suggestion, this new approach seems a lot more elegant! Looks good to me. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
First part (1/2) of fix for https://discourse.holoviz.org/t/small-multiples-aka-facetted-plots/3760/2
This will make it possible to run:
I'm actually not sure if
cuDF
should be added todf_interfaces
Before fix:
After fix: