Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding geodataframe to DataConversion #5325

Merged
merged 5 commits into from
Mar 31, 2023
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 30, 2022

First part (1/2) of fix for https://discourse.holoviz.org/t/small-multiples-aka-facetted-plots/3760/2

This will make it possible to run:

import geopandas as gpd
import hvplot.pandas

countries = gpd.read_file(gpd.datasets.get_path('naturalearth_lowres'))
countries.hvplot(geo=True, by="continent")

I'm actually not sure if cuDF should be added to df_interfaces

Before fix:
image

After fix:
image

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #5325 (6eaab76) into main (8d3a745) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5325      +/-   ##
==========================================
- Coverage   88.32%   88.29%   -0.04%     
==========================================
  Files         302      302              
  Lines       62579    62542      -37     
==========================================
- Hits        55272    55220      -52     
- Misses       7307     7322      +15     
Impacted Files Coverage Δ
holoviews/core/data/__init__.py 86.53% <100.00%> (ø)
holoviews/core/data/pandas.py 93.47% <100.00%> (+0.29%) ⬆️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maximlt
Copy link
Member

maximlt commented Jun 2, 2022

I'm also unsure about supporting cuDF or other datatypes. We'll have to get this sorted out before the next release, I'd really like this fix to be part of it.

@maximlt
Copy link
Member

maximlt commented Jul 4, 2022

@philippjfr we had a discussion about this a couple of weeks ago, can you remember what you decided about this? I remember there was a suggestion to move the interface from GeoViews to HoloViews. It would be nice if we could summarize the plan so that someone could pick up that work.

@jlstevens
Copy link
Contributor

Other than a minor renaming suggestion, this new approach seems a lot more elegant! Looks good to me.

@hoxbro hoxbro merged commit 8b62966 into holoviz:main Mar 31, 2023
@hoxbro hoxbro deleted the fix_geodataframe_by branch April 5, 2023 08:42
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants