Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #26 #29

Merged

Conversation

krkeegan
Copy link
Collaborator

No description provided.

Previously, insteon cleanup messages received by MH, would cause MH to clear the active message
withoug confirming if the cleanup message corresponded to the active message.

If multiple PLM scenes were sent sequentially, a cleanup message from one scene may have caused
MH to clear out the following scenes command.

This patch only clears the active message if the cleanup message matches the active message.
@hollie
Copy link
Owner

hollie commented Dec 22, 2012

All: could somebody please provide feedback on this fix. I'd like to merge it in but I cannot decide on my own if we should merge this pull request. I have no insteon hardware to test this fix.

@marcmerlin
Copy link
Collaborator

Ok, reviewing this smaller pull request, the reasoning behind the changes sounds reasonable, but it's hard to just tell that it's ok by just eye-ing the code.

krkeegan, can you confirm 3 weeks later than these changes have been good for you and you're pretty confident that they're ok to merge as is?

@krkeegan
Copy link
Collaborator Author

Yes, I have been running fine without issue.
On Jan 12, 2013 4:28 PM, "Marc MERLIN" [email protected] wrote:

Ok, reviewing this smaller pull request, the reasoning behind the changes
sounds reasonable, but it's hard to just tell that it's ok by just eye-ing
the code.

krkeegan, can you confirm 3 weeks later than these changes have been good
for you and you're pretty confident that they're ok to merge as is?


Reply to this email directly or view it on GitHubhttps://github.com//pull/29#issuecomment-12187451.

hollie added a commit that referenced this pull request Jan 13, 2013
…df74f1fb

Fix for Issue #26. Mered after krkeegan has been running this fix for 3 weeks without issues.
@hollie hollie merged commit 88c7b8f into hollie:master Jan 13, 2013
hplato added a commit that referenced this pull request Oct 20, 2024
GarageDoor generic object for relays and sensors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants