Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nest: Check for Blocking Issues #26

Closed
krkeegan opened this issue Jul 23, 2014 · 0 comments
Closed

Nest: Check for Blocking Issues #26

krkeegan opened this issue Jul 23, 2014 · 0 comments

Comments

@krkeegan
Copy link
Owner

Check the connect_stream routine, may need a timeout or something

For write_data, maybe this should be converted to a process_item
krkeegan added a commit that referenced this issue Jul 24, 2014
@krkeegan
Nest: Avoid Blocking on Stream Connection; Remove Calls to Die
f91fdd5 
- This adds a reconnect timer that prevents hammering the Nest server with reconnect attempts
- Add readable error messages if something goes wrong
- Completely disable interface if we receive an error that demonstrates that we will never be able to connect

Fixes #24
Partially Fixes #26
krkeegan added a commit that referenced this issue Jul 24, 2014
@krkeegan
Nest: Move Write Data to a Process Item; Check Write Response
40847ff 
This will prevent the write action from blocking if there is a delay connecting to the Nest server.  The write process is a little complicated but should be very robust, it can handle queuing multiple write commands at once.

Added a simple check of the write response, will now print an error message if the response is not OK.

Fixes #27
Fixes #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krkeegan