Fix issue 10 #11
Merged
Fix issue 10 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not commit intermediate files, .tmp files or .log files
The device_monitor function was changed in a previous commit to match any characters instead of only non-whitespace characters. This causes some existing xPL device stop funcitoning with MH, as state in #10. What was the reasoning behind this change? I guess it doesn't make sense to make MH restrictive in what messages is can process. IMHO whitespace should not cause a message to fail, as xPL is supposed to be a human-readable format.
hollie
added a commit
that referenced
this pull request
Nov 7, 2012
Fix issue 10: we don't support invalid xPL messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device_monitor function was changed in a previous commit to match any characters instead of only non-whitespace characters. This causes some existing xPL device stop funcitoning with MH, as state in #10. What was the reasoning behind this change?
I guess it doesn't make sense to make MH restrictive in what messages is can process. IMHO whitespace should not cause a message to fail, as xPL is supposed to be a human-readable format.