-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not all xPL messages are processed #10
Comments
Some more debugging info: the working version is running xPL_Items.pl v1954 (from SVN). The non-working version is the current master branch. I have two items defined:
Messages from my xpl-logger:
Both messages are received and processed by the old MH version, the master only processes the temperature and not the motion. |
The device_monitor function was changed in a previous commit to match any characters instead of only non-whitespace characters. This causes some existing xPL device stop funcitoning with MH, as state in #10. What was the reasoning behind this change? I guess it doesn't make sense to make MH restrictive in what messages is can process. IMHO whitespace should not cause a message to fail, as xPL is supposed to be a human-readable format.
Apparently, this behavior was added intentionally to support non-standard xPL messages containing spaces in their key/value pairs? http://tech.groups.yahoo.com/group/misterhouse/message/43779 |
As this is recent change implemented to support noncompliant message format, recommendation is to revert the change. If user requires this they should maintain corrected version in their own fork. |
Bug fixed in #11. |
In #10 I reverted a change in the xPL message parsing because it apparently caused the xPL processing of messages to stop working. In #10 I had the impression that the change was required to allow MisterHouse to support unsupported messages to be processed. However, I was wrong there. I misinterpreted the xPL spec. When a message is created, it contains key/value pairs. Only the name of a key/value pair cannot contain a space. The value can. This fix enables processing of messages with spaces in the value of key/value pairs to be processed again.
I'm trying to switch from my old SVN checkout to the new git branch.
I notice that not all xPL messages are processed, more specifically the messages originating from my motion sensors.
I'm trying to find out what change to xPL_Items causes this problem.
The text was updated successfully, but these errors were encountered: