-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leak when send headers in PsychicResponse #89
Conversation
Thank you very much for this PR. Everything looks good, and it's definitely a step in the right direction for using this server within ESP-IDF. As I'm not really too familiar with using ESP-IDF (which I really should learn). If it's not too much trouble, would you mind creating a simple example project in examples/esp-idf. I'm using github actions to automatically compile those and make sure that new commits don't break the existing code. |
Yes I have finished it, but there is a problem with CI, you can try to fix it. |
Wow thanks! This is a great start. I'll get this merged and try to fix the
CI stuff.
…On Sun, May 26, 2024, 14:27 Pham Viet Dzung ***@***.***> wrote:
Yes I have finished it, but there is a problem with CI, you can try to fix
it.
—
Reply to this email directly, view it on GitHub
<#89 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABEHSRGK47YTFRKLBNREXDZEISSZAVCNFSM6AAAAABIISGZFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZSGMYTSMZSGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
610fddb
to
2915498
Compare
It is Github CI image problem. I can build it in my machine. ESP IDF quite complicate but when you are making work, it is great. |
I'm going to merge this now. It looks like the CI stuff is failing on the LittleFS. All I really want is to make sure that the library itself compiles with esp-idf I might slim down that example to just a simple hello world page if I can't get the CI to compile. Thanks again for your work. |
I merge your code to use internal, and create the PR after some modification , hoeken can merge your commit first and merge me. I have no control to the project. @hoeken can to redo it and make Chris--A more happy? |
I have merge #56 and with other bug fixes and improvement: