#89 Pull request totally broke the lib

[hitecSmartHome]

I have downloaded the new version with the new fixes.
My web server no longer showed up.
I reverted back to my "old" PsychicHttp version, applyed only the "memory leak fix" and it was the same.
Webserver never answers to the requests.

First I did not notice it, but I cleared my cache on my browser and the web never loads. In fact it seems that the webserver never reaches the point to answer to requests.

I deleted the "memory leak fix" from the lib and all working fine again.

dzungpv@ec80969

[Chris--A]

@hoeken
Rather than merging #96 as a fix, PR #89 should be reverted, and resubmitted as a new PR once thoroughly tested. Additionally to keep my TemplatePrinter included, reopen and merge #56 not only to maintain proper attribution to contributors (#89 (comment)), but to ensure PR's are specific to a need, in cases like this when something needs to be reverted.

[hoeken]

Hey all, sorry about messing this one up. I was a bit overeager on the pull requests and didn't fully test them. I'll unwind this ASAP.

…

On Fri, May 31, 2024, 07:59 Christopher Andrews ***@***.***> wrote: @hoeken <https://github.com/hoeken> Rather than merging #96 <#96> as a fix, PR #89 <#89> should be reverted, and resubmitted as a new PR once thoroughly tested. Additionally to keep my TemplatePrinter included, reopen and merge #56 <#56> not only to maintain proper attribution to contributors (#89 (comment) <#89 (comment)>), but to ensure PR's are specific to a need, in cases like this when something needs to be reverted. — Reply to this email directly, view it on GitHub <#95 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABEHSRVUVWDBZRWLBBTRGLZFBQ2HAVCNFSM6AAAAABIQIVD62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRHEYDENBSHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[hitecSmartHome]

No problem. Is there a memory overflow or not?