Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] epicli init should generate specification.cloud.subscription_name for minimal cluster config. #2968

Closed
18 tasks
przemyslavic opened this issue Feb 9, 2022 · 0 comments · Fixed by #2967
Closed
18 tasks

[BUG] epicli init should generate specification.cloud.subscription_name for minimal cluster config. #2968

przemyslavic opened this issue Feb 9, 2022 · 0 comments · Fixed by #2967
Assignees
@seriva
Labels
type/bug

Comments

@przemyslavic
Copy link
Collaborator

przemyslavic commented Feb 9, 2022 •
edited
Loading

Describe the bug
When executing epicli init for Azure provider there is no specification.cloud.subscription_name key in the output file.
It means that I'm not able just to run apply after init, but I have to manually add subscription_name field, or run init --full to have full config available. But then what's the point of using epicli init since the configuration is insufficient for a cluster deployment.

How to reproduce
Steps to reproduce the behavior:

  1. execute epicli init -p azure -n test
  2. adjust it to your needs
  3. execute epicli apply

Expected behavior
Minimal cluster config should contain minimum dataset for cluster deployment.
IMO epicli init should generate exactly what we have in https://github.com/epiphany-platform/epiphany/blob/develop/schema/azure/defaults/epiphany-cluster.yml - to be agreed.

Note: Fix should be applied to all providers.

This may be done together with #2966.

Environment

  • Cloud provider: [Azure]
  • OS: [all]

epicli version: [2.0.0dev]

Additional context
Add any other context about the problem here.

DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
This was referenced Feb 9, 2022
Closed
Closed
@seriva seriva self-assigned this Feb 9, 2022
@seriva seriva mentioned this issue Feb 9, 2022
Merged
seriva added a commit that referenced this issue Feb 10, 2022
@seriva
CLI refactor to make it more consistent (#2967)
8e3e8cb 
- Re-named **epiphany/cli/engine** to **epiphany/cli/src**
- Moved epiphany/cli/models to **epiphany/cli/src/models**
- Moved epiphany/cli/helpers to **epiphany/cli/src/helpers**
- Moved the **CommandsEngine.py** inside **epiphany/cli/src/commands**
- Move **Log.py, Step.py, Config.py** to **epiphany/cli/src**
- Re-named the **CommandsEngine.py** files and classes to **Commands.py**
- Sorted all imports in all files
- Consolidated some of the helper functions
- Fix up all tests
- Also fixes #2968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seriva seriva

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CLI refactor to make it more consistent
2 participants
@seriva @przemyslavic