Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor InitEngine class to be agnostic to changes in ApplyEngine and UpgradeEngine #2944

Closed
9 of 20 tasks
to-bar opened this issue Feb 3, 2022 · 1 comment
Closed
9 of 20 tasks

Refactor InitEngine class to be agnostic to changes in ApplyEngine and UpgradeEngine #2944

to-bar opened this issue Feb 3, 2022 · 1 comment
Assignees
@seriva @przemyslavic
Labels
python Pull requests that update Python code type/improvement

Comments

@to-bar
Copy link
Contributor

to-bar commented Feb 3, 2022 •
edited by seriva
Loading

Is your feature request related to a problem? Please describe.
We have temporary workarounds here:
https://github.com/epiphany-platform/epiphany/blob/c687e8eca0347fda6dd7a0b092deafeccdb53fb6/cli/engine/InitEngine.py#L63

One was added in PR #2861

Describe the solution you'd like
Be able to add options for apply and upgrade mode without breaking init mode.

Describe alternatives you've considered
n/a

Additional context
n/a

DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
@to-bar to-bar added status/grooming-needed type/improvement python Pull requests that update Python code labels Feb 3, 2022
@to-bar to-bar changed the title [FEATURE REQUEST] Refactor InitEngine class to be agnostic to changes in ApplyEngine and UpgradeEngine Refactor InitEngine class to be agnostic to changes in ApplyEngine and UpgradeEngine Feb 3, 2022
@seriva seriva self-assigned this Feb 3, 2022
This was referenced Feb 3, 2022
Closed
Merged
seriva added a commit that referenced this issue Feb 8, 2022
@seriva
Fixes for #2944 and #2945 (#2948)
e5d9b90 
* Fixes for #2944 and #2945
* Move intentory loading code to build_io.py
* Minor fixes in debug dump.
@przemyslavic przemyslavic self-assigned this Feb 8, 2022
rafzei pushed a commit to rafzei/epiphany that referenced this issue Feb 8, 2022
@seriva @rafzei
Fixes for hitachienergy#2944 and hitachienergy#2945 (hitachienergy#2948)
ed5683a 
* Fixes for hitachienergy#2944 and hitachienergy#2945
* Move intentory loading code to build_io.py
* Minor fixes in debug dump.
@przemyslavic przemyslavic mentioned this issue Feb 9, 2022
Closed
18 tasks
@przemyslavic
Copy link
Collaborator

Tested init, init --full, apply and upgrade commands with --ping-retries and --ansible-forks flags.
Reported 2 minor issues (not related to these changes, but related to the init engine ):
#2966
#2968

@seriva seriva closed this as completed Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seriva seriva

@przemyslavic przemyslavic

Labels
python Pull requests that update Python code type/improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seriva @przemyslavic @to-bar