Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deeplink for bot visitors screen #2038

Closed
bengtan opened this issue Mar 26, 2018 · 12 comments
Closed

Deeplink for bot visitors screen #2038

bengtan opened this issue Mar 26, 2018 · 12 comments
Assignees

Comments

@bengtan
Copy link
Contributor

bengtan commented Mar 26, 2018

Need to define the format for the bot visitors screen and then implement it.


Spun out of #1904 (comment)

Let me investigate more about possible deeplink format. I guess something like bot/:server/:item?visitors=true would be more appropriate (because we need to open two screens) but I need to check if RNRF supports such format.

...

I'd prefer something like bot/:server/:item/... than botVisitors/... because, IMHO, it feels more natural / hierarchical.

With the upcoming html bot link feature, these deeplinks may very well get exposed to the wider internet ... so it'd be nice to have links structured in a way that the rest of the web is used to.

But yeah, see what you find out. I'm just voicing opinions only.

...

I think bot/server/<botID>/visitors makes the most sense - at least the way the internal code is structured. I presume that's basically what Beng was suggesting.

@bengtan
Copy link
Contributor Author

bengtan commented Mar 26, 2018

Server side ticket

Rework deeplink in geofence entry/exit push notifications
hippware/wocky#1363

@bengtan
Copy link
Contributor Author

bengtan commented Mar 26, 2018

Configuring Pipeline and Milestone to match 'parent' ticket.

@aksonov aksonov self-assigned this Mar 26, 2018
@aksonov
Copy link
Contributor

aksonov commented Mar 26, 2018

I think bot/server//visitors makes the most sense - at least the way the internal code is structured. I presume that's basically what Beng was suggesting.

Agree. I will implement it. Example:
tinyrobotStaging://bot/staging.dev.tinyrobot.com/835bff2a-2df3-11e8-bc2a-0a580a0205ef/visitors

aksonov pushed a commit that referenced this issue Mar 26, 2018
@bengtan
Copy link
Contributor Author

bengtan commented Mar 27, 2018

The server side ticket has been merged and will go out in the next Testing/Staging deploy, whenever that is.

@zavreb
Copy link

zavreb commented Apr 3, 2018

Per this, can we title the build so I know which one it is @bengtan, I'll look at changelog in the interim.

@bengtan
Copy link
Contributor Author

bengtan commented Apr 4, 2018

@zavreb:

The server side ticket (hippware/wocky#1363) is part of version 2018.3.29+r6558ce9 (as recorded in the changelog). This version has been deployed to Testing already recently (and then superseded by a subsequent version).

We won't be deploying to 2018.3.29+r6558ce9 per se to Staging though. We're skipping that and will be releasing something newer to Staging. However, since it's 'something newer', I don't know what the version string of the new version will be.

@bengtan
Copy link
Contributor Author

bengtan commented Apr 4, 2018

Per this, can we title the build so I know which one it is @bengtan, I'll look at changelog in the interim.

It's been deployed to Staging when 2018.4.4+r9d2357b was deployed to Staging.

So I think this ticket warrants re-testing.

@bengtan
Copy link
Contributor Author

bengtan commented Apr 4, 2018

@zavreb, @mstidham: ^^

@mstidham
Copy link

mstidham commented Apr 4, 2018

Verified on Staging Version: 2.4.0

@zavreb
Copy link

zavreb commented Apr 10, 2018

LGTM. Verified on Staging 2.5.0.

@zavreb
Copy link

zavreb commented May 17, 2018

Verified on Prod 2.6.7

@mstidham
Copy link

Verified on Production Version: 2.6.7

@zavreb zavreb closed this as completed May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants