Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diagrams): [sequenceDiagram] remove unnecessary stroke in message text #244

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

hikerpig
Copy link
Owner

@hikerpig hikerpig commented Jan 5, 2024

fixes #241

Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pintorajs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 1:53pm

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (87f80b1) 91.06% compared to head (4b10f73) 91.90%.
Report is 111 commits behind head on master.

Files Patch % Lines
packages/pintora-diagrams/src/class/db.ts 92.98% 8 Missing ⚠️
packages/pintora-diagrams/src/dot/artist.ts 92.20% 6 Missing ⚠️
packages/pintora-diagrams/src/class/artist.ts 98.00% 4 Missing ⚠️
packages/pintora-diagrams/src/activity/artist.ts 92.30% 3 Missing ⚠️
packages/pintora-diagrams/src/class/config.ts 90.47% 2 Missing ⚠️
packages/pintora-diagrams/src/util/graph.ts 33.33% 2 Missing ⚠️
packages/pintora-diagrams/src/sequence/artist.ts 95.45% 1 Missing ⚠️
...kages/pintora-diagrams/src/sequence/artist/loop.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   91.06%   91.90%   +0.84%     
==========================================
  Files          69       88      +19     
  Lines        3994     5052    +1058     
  Branches      762      889     +127     
==========================================
+ Hits         3637     4643    +1006     
- Misses        357      409      +52     
Flag Coverage Δ
unittests 91.90% <96.59%> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hikerpig hikerpig force-pushed the fix-sequence-message-font branch from 7c91c61 to 4b10f73 Compare January 5, 2024 13:50
@hikerpig hikerpig merged commit 2df9693 into master Jan 5, 2024
11 checks passed
@hikerpig hikerpig deleted the fix-sequence-message-font branch January 7, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary stroke around note text results in hard to read content
1 participant