Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary stroke around note text results in hard to read content #241

Closed
titanism opened this issue Jan 5, 2024 · 3 comments · Fixed by #244
Closed

Unnecessary stroke around note text results in hard to read content #241

titanism opened this issue Jan 5, 2024 · 3 comments · Fixed by #244
Assignees
@hikerpig
Labels
bug Something isn't working

Comments

@titanism
Copy link

titanism commented Jan 5, 2024

Screen Shot 2024-01-04 at 7 15 47 PM Screen Shot 2024-01-04 at 7 15 52 PM
@titanism
Copy link
Author

titanism commented Jan 5, 2024

Looks like missing noteTextStroke config or something https://github.com/hikerpig/pintora/blob/4e3ea6f759ed65234f3fe681c10fc8446963ba2e/packages/pintora-core/src/themes/base.ts#L40C3-L40C16

@titanism titanism mentioned this issue Jan 5, 2024
Open
@hikerpig
Copy link
Owner

hikerpig commented Jan 5, 2024 •
edited
Loading

The stroke around message text needs to be removed. I will fix it this week.

@hikerpig hikerpig self-assigned this Jan 5, 2024
@hikerpig hikerpig added the bug Something isn't working label Jan 5, 2024
@hikerpig hikerpig mentioned this issue Jan 5, 2024
Merged
@hikerpig
Copy link
Owner

hikerpig commented Jan 5, 2024

I've merged the fix but this needs to wait for next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hikerpig hikerpig

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(diagrams): [sequenceDiagram] remove unnecessary stroke in message text hikerpig/pintora
2 participants
@hikerpig @titanism