Split off from 0.10.0 without the reworked authentication fixes #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only add DFSPathResolver if both client and server support DFS * Fix indentation problems * Fix incorrectly reformatted javadoc * Format using java formatter * One more indentation fix
…y. (#609) * stop closing the dfs share connection immediately. * Add explanatory comment Co-authored-by: Jeroen van Erp <[email protected]>
For each smb3 packet there's an info log message which produces a tremendous amount of output. I would suggest to reduce log level to debug (or trace; similarly as in one of the other packet reciever classes).
* Read fileId of FileIdBothDirectoryInformation into a long * Read fileId of FileIdFullDirectoryInformation into a long
- Added GitHub badge for Build SMBJ - Corrected Codacy badge link - Removed bintray badge link - Removed Travis CI badge and configuration - Removed Java profiler link - Removed CircleCI configuration - Removed unused github-ci configuration
Fixes issue seen in the wild where unnecessary padding at the end of an ACE confused Smbj (but not Windows).
… bytesLeft count for SMB2Write (fixes #669) * GzipOutputStream integration test * Ensure that enough bytes are cached from InputStream to get a correct bytesLeft count for SMB2Write Co-authored-by: Stanislav Kardashov <[email protected]> Co-authored-by: Jeroen van Erp <[email protected]>
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/hierynomus/smbj/762.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/hierynomus/smbj/762.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
Signed-off-by: Jeroen van Erp <[email protected]>
Signed-off-by: Jeroen van Erp <[email protected]>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Signed-off-by: Jeroen van Erp <[email protected]>
| AuthenticateResponse response = new AuthenticateResponse(); | ||
| response.setWindowsVersion(serverNtlmChallenge.getVersion()); | ||
| if (serverNtlmChallenge.getTargetInfo() != null && serverNtlmChallenge.getTargetInfo().hasAvPair(AvId.MsvAvNbComputerName)) { | ||
| response.setNetBiosName((String) serverNtlmChallenge.getTargetInfo().getAvPair(AvId.MsvAvNbComputerName).getValue()); |
There was a problem hiding this comment.
NULL_DEREFERENCE: object returned by serverNtlmChallenge.getTargetInfo().getAvPair(com.hierynomus.ntlm.av.AvId.MsvAvNbComputerName) could be null and is dereferenced at line 129.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Signed-off-by: Jeroen van Erp <[email protected]>
Required to put withIntegrity = false still, due to missing mechListMIC Signed-off-by: Jeroen van Erp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.