Added null check and rename field

hierynomus · May 11, 2023 · 9055e3a · 9055e3a
1 parent 5f1b9de
commit 9055e3a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/main/java/com/hierynomus/ntlm/functions/NtlmFunctions.java b/src/main/java/com/hierynomus/ntlm/functions/NtlmFunctions.java
@@ -192,7 +192,9 @@ public byte[] getNTLMv2ClientChallenge(TargetInfo targetInformation) {
         ccBuf.putLong(nowAsFileTime); // Timestamp (8)
         ccBuf.putRawBytes(challengeFromClient); // ChallengeFromClient (8)
         ccBuf.putUInt32(0); // Reserved3 (4)
-        targetInformation.writeTo(ccBuf); // AvPairs (variable)
+        if (targetInformation != null) {
+            targetInformation.writeTo(ccBuf); // AvPairs (variable)
+        }
         ccBuf.putUInt32(0); // Last AV Pair indicator
 
         return ccBuf.getCompactData();

diff --git a/src/main/java/com/hierynomus/ntlm/messages/NtlmAuthenticate.java b/src/main/java/com/hierynomus/ntlm/messages/NtlmAuthenticate.java
@@ -124,12 +124,12 @@ public byte[] getVersion() {
         return plainBuffer.getCompactData();
     }
 
-    private int writeOffsettedByteArrayFields(Buffer.PlainBuffer buffer, byte[] array, int offset) {
-        byte[] _array = array != null ? array : EMPTY;
-        buffer.putUInt16(_array.length); // ArrayLen
-        buffer.putUInt16(_array.length); // ArrayMaxLen
+    private int writeOffsettedByteArrayFields(Buffer.PlainBuffer buffer, byte[] bytes, int offset) {
+        byte[] arr = bytes != null ? bytes : EMPTY;
+        buffer.putUInt16(arr.length); // ArrayLen
+        buffer.putUInt16(arr.length); // ArrayMaxLen
         buffer.putUInt32(offset); // ArrayOffset
-        return offset + _array.length;
+        return offset + arr.length;
     }
 
     private byte[] ensureNotNull(byte[] possiblyNull) {