fix: Validate CustomFees input arrays in UpdateTokenCustomFeesDecoder
#15520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stanimir Stoyanov <[email protected]>
Signed-off-by: Stanimir Stoyanov <[email protected]>
stoyanov-st
requested review from
a team and
tinker-michaelj
as code owners
Signed-off-by: Stanimir Stoyanov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15520 +/- ##
==========================================
Coverage 58.25% 58.25%
- Complexity 21610 21614 +4
==========================================
Files 2781 2781
Lines 109269 109279 +10
Branches 11176 11179 +3
==========================================
+ Hits 63650 63660 +10
Misses 41761 41761
Partials 3858 3858
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
netopyr
added a commit
that referenced
this pull request
Sep 19, 2024
* develop: (22 commits) test: New HAPI test for TokenAirdrop transaction (#15348) test: unit test verifySyncInvalidEd25519() is not stable (#15534) chore: add `TracerBinding` interface for `TransactionExecutors`. (#15480) chore: Add missing javadocs in Consensus Service (#15299) fix: Validate `CustomFees` input arrays in `UpdateTokenCustomFeesDecoder` (#15520) feat: migrate event serialization to protobuf (#15417) fix: 15494: Improve VirtualLeafRecord serialization to bytes during flushes (#15512) docs: tss block signing proposal (#15160) fix: 15438: Eliminate busy loop in HalfDiskHashMap.endWriting() (#15439) build: cleanup settings.gradle.kts / remove build.gradle.kts (#15470) test: fix CryptographyTests (#15529) fix: recreate block hash from state (#15444) docs: Proposal Process Update - Specify post-acceptance non-material update procedure (#15447) chore: testnet event hashing (#15432) fix: 15167: Remove timeout from reconnect/rehash Iterators (#15468) chore: remove snapshot ops (#15462) feat: Add TokenUpdateNFTs as a smart contract operation v2 (#15445) feat: introduce PbjRecordHasher and RosterUtils.hash(Roster) (#15457) fix: Precision loss for gas calculation of HTS system contracts v2 (#15446) chore: correct the variable name in roster.proto (#15465) ... # Conflicts: # hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/scope/HandleHederaOperations.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses a fail-fast way of handling invalid amount of fees provided in contract call.
Related issue(s):
Fixes #945
Notes for reviewer:
Checklist