Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Proposal Process Update - Specify post-acceptance non-material update procedure #15447

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

poulok
Copy link
Contributor

@poulok poulok commented Sep 12, 2024

Description:
Updates the proposal process to specify how non-material changes can be made to accepted proposals.

@poulok poulok added this to the v0.55 milestone Sep 12, 2024
@poulok poulok self-assigned this Sep 12, 2024
@poulok poulok requested review from a team as code owners September 12, 2024 17:17
@poulok poulok changed the title Proposal Process Update: Specify post-acceptance non-material update procedure docs: Proposal Process Update - Specify post-acceptance non-material update procedure Sep 12, 2024
mxtartaglia-sl
mxtartaglia-sl previously approved these changes Sep 12, 2024
jsync-swirlds
jsync-swirlds previously approved these changes Sep 12, 2024
artemananiev
artemananiev previously approved these changes Sep 12, 2024
imalygin
imalygin previously approved these changes Sep 13, 2024
kfa-aguda
kfa-aguda previously approved these changes Sep 13, 2024
Signed-off-by: Kelly Greco <[email protected]>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7a4616b) 108968 67303 61.76%
Head commit (1a7eb0d) 109068 (+100) 67383 (+80) 61.78% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15447) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.25%. Comparing base (7a4616b) to head (1a7eb0d).
Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #15447      +/-   ##
=============================================
+ Coverage      58.22%   58.25%   +0.02%     
- Complexity     21573    21610      +37     
=============================================
  Files           2779     2781       +2     
  Lines         109151   109269     +118     
  Branches       11163    11176      +13     
=============================================
+ Hits           63554    63650      +96     
- Misses         41738    41761      +23     
+ Partials        3859     3858       -1     

see 37 files with indirect coverage changes

Impacted file tree graph

@poulok poulok merged commit 9df6208 into develop Sep 17, 2024
50 of 52 checks passed
@poulok poulok deleted the update-proposal-process branch September 17, 2024 12:55
netopyr added a commit that referenced this pull request Sep 19, 2024
* develop: (22 commits)
  test: New HAPI test for TokenAirdrop transaction (#15348)
  test: unit test verifySyncInvalidEd25519() is not stable (#15534)
  chore: add `TracerBinding` interface for `TransactionExecutors`. (#15480)
  chore: Add missing javadocs in Consensus Service (#15299)
  fix: Validate `CustomFees` input arrays in `UpdateTokenCustomFeesDecoder` (#15520)
  feat: migrate event serialization to protobuf (#15417)
  fix: 15494: Improve VirtualLeafRecord serialization to bytes during flushes (#15512)
  docs: tss block signing proposal (#15160)
  fix: 15438: Eliminate busy loop in HalfDiskHashMap.endWriting() (#15439)
  build: cleanup settings.gradle.kts / remove build.gradle.kts (#15470)
  test: fix CryptographyTests (#15529)
  fix: recreate block hash from state (#15444)
  docs: Proposal Process Update - Specify post-acceptance non-material update procedure (#15447)
  chore: testnet event hashing (#15432)
  fix: 15167: Remove timeout from reconnect/rehash Iterators (#15468)
  chore: remove snapshot ops (#15462)
  feat: Add TokenUpdateNFTs as a smart contract operation v2 (#15445)
  feat: introduce PbjRecordHasher and RosterUtils.hash(Roster) (#15457)
  fix: Precision loss for gas calculation of HTS system contracts v2 (#15446)
  chore: correct the variable name in roster.proto (#15465)
  ...

# Conflicts:
#	hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/scope/HandleHederaOperations.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants