Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix JDBC batching #904

Merged
merged 1 commit into from
Jul 26, 2021
Merged

fix JDBC batching #904

merged 1 commit into from
Jul 26, 2021

Conversation

gavinking
Copy link
Member

Attempt to fix #877.

WDYT @DavideD?

@DavideD DavideD merged commit 75b7403 into main Jul 26, 2021
@DavideD DavideD deleted the 877 branch July 26, 2021 14:09
@DavideD
Copy link
Member

DavideD commented Jul 26, 2021

It seems to work.

Thanks @gavinking.
We still need a way to test that batching is actually used when we want to use it.

@gavinking
Copy link
Member Author

yeah well. that's much harder

@DavideD
Copy link
Member

DavideD commented Jul 26, 2021

I think testing that the connection is an instance of BatchingConnection should be doable.
Not foolproof but better than nothing. @blafond can you have a look at it please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Value of hibernate.jdbc.batch_size is ignored
2 participants
@gavinking @DavideD