Value of hibernate.jdbc.batch_size is ignored

[DavideD]

It doesn't matter what we set it to, it's always 0.

The reason is that in SessionFactoryOptionsBuilder, there's a check to see if the database supports batching and it always return false. It happens because we don't extract the info from the database

[gavinking]

What I don't understand about this is that I thought we had tests that test statement batching.

[DavideD]

Well... those tests check that if you set the property everything works fine, they don't really test that it is actually using batching (as far as I remember).

[gavinking]

Well, you're right, BatchingConnection is never instantiated. So whatever tests we have (ReactiveSessionTest, FTR) certainly don't test that batching actually happens. (Which is not actually surprising, since it's not observable via the API.)

But what is weird is that I certainly did test that BatchingConnection works when I first wrote it.

[gavinking]

Well... those tests check that if you set the property everything works fine, they don't really test that it is actually using batching (as far as I remember).

Yes, right, that's what I just realized.

[DavideD]

Will this be solved by this other issue?

[gavinking]

Rrrrm, not automatically, but in principle perhaps that's one option for where we could hook in. I'm not sure.

[gavinking]

@DavideD isn't there a simpler temporary solution we could use?

Like, do it in ReactiveSessionFactoryBuilderService.createSessionFactoryBuilder() and ReactiveEntityManagerFactoryBuilder.build(), for example?