Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Limit the maximum number of linter instances to run in parallel #399

Closed
wants to merge 1 commit into from

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Nov 23, 2021

Note that #398 requires this PR, otherwise HHClientLinter would be running out of memory.

@fredemmott
Copy link
Contributor

Is the number of linters the problem, or the number of hh_client subprocesses? You might want to look at generalizing/reuing ParserQueue just for the hh_client --lint subprocess calls, rather than the linters as a whole.

Also, what's running out of memory? The container/environment/system, or is HHVM hitting an internal limit?

@Atry Atry closed this Nov 23, 2021
@Atry
Copy link
Contributor Author

Atry commented Nov 23, 2021

Close this PR in favor of #400 according to the feedback

@Atry Atry deleted the limit-concurrency branch November 26, 2021 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants