Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Dogfood HHClientLinter for hhast source code #398

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Nov 23, 2021

All the existing errors are ignored for now

@Atry Atry force-pushed the dogfood-hh-client-linter branch from 241adc7 to aa7716b Compare November 23, 2021 22:05
@Atry
Copy link
Contributor Author

Atry commented Nov 23, 2021

Limit to concurrency for hh_client to 2, which means 2*CPU cores of processes, otherwise it would still run out of memory in my Docker Desktop.

The running time between concurrency=2 and concurrency=32 is not changed significantly on Github Actions CI.

@Atry Atry merged commit 6087e96 into hhvm:main Nov 23, 2021
@Atry Atry deleted the dogfood-hh-client-linter branch November 23, 2021 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants