Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(open_graph): language is 'en' by default #3660

Merged
merged 1 commit into from
Aug 16, 2019
Merged

test(open_graph): language is 'en' by default #3660

merged 1 commit into from
Aug 16, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Aug 10, 2019 •
edited
Loading

What does it do?

After #3654, language: defaults to en, thus no longer empty by default.

How to test

git clone -b locale https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.153% when pulling fed07e8 on curbengh:locale into 48b506d on hexojs:master.

This was referenced Aug 15, 2019
Merged
Merged
@curbengh curbengh requested a review from a team August 16, 2019 07:43
@yoshinorin yoshinorin merged commit 49c7d4a into hexojs:master Aug 16, 2019
@yoshinorin yoshinorin added this to the v4.0.0 milestone Aug 16, 2019
@curbengh curbengh deleted the locale branch August 17, 2019 07:58
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@curbengh
test(open_graph): language is 'en' by default (hexojs#3660)
28d315b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@curbengh @coveralls @yoshinorin