Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set english as default #3654

Merged
merged 1 commit into from
Aug 7, 2019
Merged

fix: set english as default #3654

merged 1 commit into from
Aug 7, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Aug 6, 2019 •
edited
Loading

What does it do?

Set default language as english. to match the docs. Main purpose is to set it in <html>, as recommended by W3C.

I will update hexo-starter too. Edit: hexojs/hexo-starter#12

How to test

git clone -b default-lang https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.153% when pulling d2ed468 on curbengh:default-lang into 0621184 on hexojs:master.

@curbengh curbengh merged commit 2df5555 into hexojs:master Aug 7, 2019
@curbengh curbengh deleted the default-lang branch August 7, 2019 00:24
@yoshinorin yoshinorin added this to the v4.0.0 milestone Aug 7, 2019
This was referenced Aug 8, 2019
Merged
Merged
@curbengh curbengh mentioned this pull request Sep 28, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomap tomap tomap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@curbengh @coveralls @tomap @yoshinorin