Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up pip-grep in the not silent case #298

Merged
merged 1 commit into from
Jun 10, 2016
Merged

clean up pip-grep in the not silent case #298

merged 1 commit into from
Jun 10, 2016

Conversation

chadwhitacre
Copy link
Contributor

The extraneous format call is harmless in itself, but it's possible for requirement.req to be None here, which results in AttributeError: 'NoneType' object has no attribute 'project_name'.

The extraneous `format` call is harmless in itself, but it's possible for `requirement.req` to be `None` here, which results in `AttributeError: 'NoneType' object has no attribute 'project_name'`.
@chadwhitacre chadwhitacre changed the title clean up pip-pop in the not silent case clean up pip-grep in the not silent case May 10, 2016
@kennethreitz kennethreitz merged commit 3cff2e3 into heroku:master Jun 10, 2016
@kennethreitz
Copy link
Contributor

✨ 🍰 ✨

@chadwhitacre chadwhitacre deleted the preen-pip-grep branch June 11, 2016 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants