Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip-grep does not match local packages #299

Closed
chadwhitacre opened this issue May 10, 2016 · 3 comments
Closed

pip-grep does not match local packages #299

chadwhitacre opened this issue May 10, 2016 · 3 comments

Comments

@chadwhitacre
Copy link
Contributor

chadwhitacre commented May 10, 2016

Reticketing from gratipay/inside.gratipay.com#612 (comment) ...

Steps

  1. cd vendor/pip-pop/
  2. echo ./foo.zip > requirements.txt
  3. ./pip-grep requirements.txt foo

Expected

"Package foo found!"

Actual

"Not found."

(Well, the actual actual is #298. ;-)

@chadwhitacre chadwhitacre changed the title pip-grep does not match locally vendored packages pip-grep does not match local packages May 10, 2016
chadwhitacre referenced this issue in gratipay/buildpack-python May 10, 2016
@kennethreitz
Copy link
Contributor

This is an intentional design decision. You can't tell anything about something like a zip-file without opening and inspecting it.

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented May 11, 2016

What does pip-grep do with non-zip-files? Does it hit the network to get more information about them? If it's willing to hit the network, why isn't it willing to peak inside local files?

Barring that, any suggested workarounds short of forking the buildpack?

@kennethreitz
Copy link
Contributor

Hmm, I'm not sure. I feel like zipfiles (and any local files, actually) is outside the scope of (automatic installation of system sub-deps / uninstallation of no-longer-listed packages). This is intended for augmenting pip's management of pypi-index-style package distributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants