Make corepack binaries available during runtime #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colincasey
force-pushed
the
fix_corepack_binaries_at_runtime
branch
2 times, most recently
from
7ca34dc to
65778f2
Compare
colincasey
force-pushed
the
fix_corepack_binaries_at_runtime
branch
from
65778f2 to
4846020
Compare
colincasey
changed the title
joshwlewis
approved these changes
May 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While setting up a pnpm walkthrough I noticed that, at runtime, the
pnpmbinary wasn't available. This PR ensures that any package manager downloaded using Corepack is available at runtime by:COREPACK_HOMEto<build_dir>/.heroku/corepackso that downloads are placed with the app during the build phase (similar to Node and other binaries)COREPACK_HOMEto$HOME/.heroku/corepackin thenodejs.shscript that executes at runtime so that Corepack is aware of the download directory when using its jumper scriptsAlso, Hatchet tests have been added to verify this behavior.