Make Corepack installed binaries available at runtime (#1250)

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## [Unreleased]
 
+- Make [Corepack](https://nodejs.org/api/corepack.html) installed binaries available at runtime. ([#1250](https://github.com/heroku/heroku-buildpack-nodejs/pull/1250))
 
 ## [v245] - 2024-04-29
 

bin/compile

@@ -61,6 +61,8 @@ source "$BP_DIR/lib/yarn-2.sh"
 
 export PATH="$BUILD_DIR/.heroku/node/bin:$BUILD_DIR/.heroku/yarn/bin":$PATH
 
+export COREPACK_HOME="$BUILD_DIR/.heroku/corepack"
+
 LOG_FILE=$(mktemp -t node-build-log.XXXXX)
 echo "" > "$LOG_FILE"
 

profile/nodejs.sh

@@ -1,6 +1,8 @@
 export PATH="$HOME/.heroku/node/bin:$HOME/.heroku/yarn/bin:$PATH:$HOME/bin:$HOME/node_modules/.bin"
 export NODE_HOME="$HOME/.heroku/node"
 export NODE_ENV=${NODE_ENV:-production}
+export COREPACK_HOME="$HOME/.heroku/corepack"
+
 
 # If the user has opted into the feature
 if [[ -n "$HEROKU_METRICS_URL" ]] && \

spec/ci/corepack_spec.rb

@@ -0,0 +1,18 @@
+require_relative '../spec_helper'
+
+describe "corepack support" do
+  it "should be able to run an app that installs pnpm using corepack" do
+    app = Hatchet::Runner.new("spec/fixtures/repos/corepack-pnpm")
+    app.deploy do |app|
+      expect(successful_body(app).strip).to eq("Hello from corepack-pnpm")
+    end
+  end
+
+  it "should be able to run an app that installs yarn using corepack" do
+    app = Hatchet::Runner.new("spec/fixtures/repos/corepack-yarn")
+    app.deploy do |app|
+      expect(successful_body(app).strip).to eq("Hello from corepack-yarn")
+    end
+  end
+end
+

spec/fixtures/repos/corepack-pnpm/Procfile

@@ -0,0 +1 @@
+web: pnpm run start

spec/fixtures/repos/corepack-pnpm/index.js

@@ -0,0 +1,12 @@
+const express = require('express')
+
+const app = express()
+const port = process.env.PORT || 3000
+
+app.get('/', (req, res) => {
+    res.send('Hello from corepack-pnpm')
+})
+
+app.listen(port, () => {
+    console.log(`corepack-pnpm app listening on port ${port}`)
+})

spec/fixtures/repos/corepack-pnpm/package.json

@@ -0,0 +1,16 @@
+{
+  "name": "corepack-pnpm",
+  "version": "1.0.0",
+  "description": "",
+  "main": "index.js",
+  "scripts": {
+    "start": "node index.js"
+  },
+  "keywords": [],
+  "author": "",
+  "license": "ISC",
+  "packageManager": "[email protected]+sha256.0624e30eff866cdeb363b15061bdb7fd9425b17bc1bb42c22f5f4efdea21f6b3",
+  "dependencies": {
+    "express": "^4.19.2"
+  }
+}