Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extract_requirement_version return an Option #294

Merged
merged 1 commit into from
Nov 29, 2024

Commits on Nov 28, 2024

  1. Make extract_requirement_version return an Option

    Rust 1.83 added support for `Option::expect` in `const` contexts:
    https://blog.rust-lang.org/2024/11/28/Rust-1.83.0.html
    
    This means we can now return an `Option` from
    `extract_requirement_version` instead of panicing within it,
    which makes it easier to test the function, and avoids the need
    to explain that the panic inside the function was actually safe.
    edmorley committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    943e788 View commit details
    Browse the repository at this point in the history