Make extract_requirement_version return an Option
#294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.83 added support for `Option::expect` in `const` contexts: https://blog.rust-lang.org/2024/11/28/Rust-1.83.0.html This means we can now return an `Option` from `extract_requirement_version` instead of panicing within it, which makes it easier to test the function, and avoids the need to explain that the panic inside the function was actually safe.
edmorley
added
skip changelog
Malax
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.83 added support for
Option::expectinconstcontexts:https://blog.rust-lang.org/2024/11/28/Rust-1.83.0.html#stabilized-apis
This means we can now return an
Optionfromextract_requirement_versioninstead of panicing within it, which makes it easier to test the function, and avoids the need to explain that the panic inside the function was actually safe.