-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed to intuitive casting, removed dtype tests from basic test class #598
Conversation
The dtype comparison was removed as the basic tests works with numpy, which does safe casting instead of intuitive casting.
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
==========================================
- Coverage 97.48% 97.46% -0.02%
==========================================
Files 77 77
Lines 15429 15396 -33
==========================================
- Hits 15041 15006 -35
- Misses 388 390 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Does the promote_types() documentation need an update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Changelog needs an update
Claudia's comment:
- Update to the docstring with double quotation marks
docstrings have double quotation marks now, changelog is updated |
Description
The dtype comparison was removed as the basic tests works with numpy, which does safe casting instead of intuitive casting. other changes were adjustments for types
Issue/s resolved:
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no