Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for lossy type promotion #597

Closed
ClaudiaComito opened this issue Jun 16, 2020 · 4 comments
Closed

Allow for lossy type promotion #597

ClaudiaComito opened this issue Jun 16, 2020 · 4 comments

Comments

@ClaudiaComito
Copy link
Contributor

we are currently doing safe casting, i.e. precision preserving, meaning promote_type(int32, float32) -> float64 as float32 might be lossy in the conversion

Issue created from a Mattermost message by @Markus-Goetz.
@ClaudiaComito
Copy link
Contributor Author

@ClaudiaComito attached a message from @Markus-Goetz

Since we are doing probabilistic/heuristic stuff often anyway, I would be fine with natural expectation over safe casting

@Markus-Goetz
Copy link
Member

Daniel has implemented something like this already. We called it "intuitive" casting. The table is already in the master. If you can find more example of where we should relax the casting, based on the table, we can implement this fairly quickly

@coquelin77
Copy link
Member

give me a second and i will push a branch to the master. im just updating the docstring

@ClaudiaComito ClaudiaComito added this to the v0.5.0 milestone Jun 30, 2020
@Markus-Goetz
Copy link
Member

Closed by #598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Markus-Goetz @coquelin77 @ClaudiaComito