Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a named function for the middleware over an anonymous #165

Closed
wants to merge 1 commit into from
Closed

Use a named function for the middleware over an anonymous #165

wants to merge 1 commit into from

Conversation

oliviertassinari
Copy link

@oliviertassinari oliviertassinari commented Feb 6, 2018

It's making the investigation of performance issues easier.
@EvanHahn
Copy link
Member

EvanHahn commented Feb 6, 2018 via email

@EvanHahn
Copy link
Member

EvanHahn commented Feb 9, 2018

I did this myself in 73a5dd7 because I wanted to change the name and add tests. This has now been deployed in [email protected].

Thanks for reporting this! Even though I did my own version of the commit, feel free to add yourself to the contributors list.

@EvanHahn EvanHahn closed this Feb 9, 2018
@oliviertassinari oliviertassinari deleted the patch-1 branch February 9, 2018 16:09
@oliviertassinari
Copy link
Author

oliviertassinari commented Feb 9, 2018

@EvanHahn Awesome, thanks!

I did this myself in 73a5dd7 because I wanted to change the name and add tests.

You could have amended my commit in this pull-request. You have missed the opportunity to add one more contributor ;)
capture d ecran 2018-02-09 a 17 10 52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants