Use a named function for the middleware over an anonymous #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abernix
reviewed
Mar 12, 2018
| @@ -36,7 +36,7 @@ export function graphqlExpress( | |||
| ); | |||
| } | |||
|
|
|||
| return (req: express.Request, res: express.Response, next): void => { | |||
| return function graphql(req: express.Request, res: express.Response, next): void { | |||
There was a problem hiding this comment.
Would it be better to call this graphqlExpressHandler?
It's making the investigation of performance issues easier.
As originally reported in [0], this should make debugging performance issues easier, since the name of the function will be properly displayed/shown in flame-graphs. [0]: #827
|
I've gone ahead and extended this (in 7d7aceb) to be a consistent pattern across the various middleware variants (Express, Koa, etc.) and also included the GraphiQL middlewares too. Thanks for opening this originally! |
|
Thanks! |
|
This should be published in |
ShiyamRajan
pushed a commit
to ShiyamRajan/apollo-server-lambda
that referenced
this pull request
Nov 2, 2018
As originally reported in [0], this should make debugging performance issues easier, since the name of the function will be properly displayed/shown in flame-graphs. [0]: apollographql/apollo-server#827
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's making the investigation of performance issues easier.
New Relic
Chrome Dev Tool (express-graphql but I'm considering moving to apollo-server)
Related to: