Consistent statusline padding #9691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only potential regression is that |
hamrik
force-pushed
the
consistent_statusline_padding
branch
2 times, most recently
from
7e39537 to
d5a28ac
Compare
Statusline elements were inconsistent in their use of spacing: some had margins, some didn't, some reserved space for when they were not in use while others did not. This PR adjusts each element to act consistently, without involving the statusline renderer: - Every statusline element hides when not in use. - Every statusline element has a 1 space margin. This creates a 2 space gap between every element, avoiding confusion with spaces between words, and a 1 space padding from the statusline edges. Since elements handle their own spacing, special cases like `color-modes`, `spacer` and `separator` work correctly.
Spinner no longer reserves space to remain consistent with other elements. To prevent it from shifting elements around whenever the LSP is busy, move the spinner to the innermost position on the left, next to `file-modification-indicator`, where it cannot push other elements around.
For a long time there was a TODO for handling more than just the first connected language server on a given buffer. Now we pick the first busy server to display the spinner for, so we can indicate if any attached server is busy.
hamrik
force-pushed
the
consistent_statusline_padding
branch
from
d5a28ac to
f1b1dac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8061.
Statusline elements were inconsistent in their use of spacing: some had margins, some didn't, some reserved space for when they were not in use while others did not.
This PR adjusts each element to act consistently, without involving the statusline renderer:
This creates a 2 space gap between every element, avoiding confusion with spaces between words, and a 1 space padding from the statusline edges.
Since elements handle their own padding, special cases like
color-modes,spacerandseparatorwork correctly.