Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

color-modes artifact with splits #10006

Closed
ascarter opened this issue Mar 25, 2024 · 2 comments
Closed

color-modes artifact with splits #10006

ascarter opened this issue Mar 25, 2024 · 2 comments
Labels
C-bug Category: This is a bug

Comments

@ascarter
Copy link
Contributor

Summary

Enabling color-modes and configuring a theme with colors for insert and select shows render artifact on splits. This is a regression.

Reproduction Steps

Ensure you are using a theme that sets a color for the color-modes

  1. hx helix-term/src/application.rs
  2. :vs helix-term/src/commands.rs
  3. i or v to get to insert or select mode -
Screenshot 2024-03-25 at 13 01 26 Screenshot 2024-03-25 at 13 02 18

Expected that the color should be applied only to the active window

Helix log

~/.cache/helix/helix.log 
2024-03-25T13:46:33.254 helix_term::application [DEBUG] received editor event: Redraw
2024-03-25T13:46:33.256 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:35.300 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:35.549 helix_term::application [DEBUG] received editor event: IdleTimer
2024-03-25T13:46:35.691 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:35.786 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:35.928 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:35.930 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:39.034 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:39.035 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:39.158 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:39.160 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:39.284 helix_term::application [DEBUG] received editor event: IdleTimer
2024-03-25T13:46:39.291 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:39.292 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:40.527 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:40.528 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:40.781 helix_term::application [DEBUG] received editor event: IdleTimer
2024-03-25T13:46:41.671 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:41.672 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:41.914 helix_term::application [DEBUG] received editor event: IdleTimer
2024-03-25T13:46:42.675 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:42.677 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:42.925 helix_term::application [DEBUG] received editor event: IdleTimer
2024-03-25T13:46:43.198 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:43.199 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:43.449 helix_term::application [DEBUG] received editor event: IdleTimer
2024-03-25T13:46:43.802 helix_term::commands::typed [DEBUG] quitting...
2024-03-25T13:46:43.804 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:43.805 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:44.283 helix_term::commands::typed [DEBUG] quitting...
2024-03-25T13:46:44.283 helix_term::job [DEBUG] waiting on jobs...
2024-03-25T13:46:44.294 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:45.699 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:45.960 helix_term::application [DEBUG] received editor event: IdleTimer
2024-03-25T13:46:46.023 helix_term::commands::typed [DEBUG] quitting...
2024-03-25T13:46:46.025 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:46.196 helix_term::commands::typed [DEBUG] quitting...
2024-03-25T13:46:46.196 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-03-25T13:46:46.196 helix_term::job [DEBUG] waiting on jobs...
2024-03-25T13:46:46.196 helix_term::job [DEBUG] waiting on jobs...

Platform

macOS

Terminal Emulator

Apple Terminal

Installation Method

source

Helix Version

23.10-449-g1d108782
@ascarter ascarter added the C-bug Category: This is a bug label Mar 25, 2024
@ascarter
Copy link
Contributor Author

Maybe could be related the spacing changes for spinners in status line? #9691

@archseer
Copy link
Member

Likely #9122

\cc @hamrik

postsolar pushed a commit to postsolar/helix that referenced this issue Apr 4, 2024
@archseer @postsolar
Fix regression in color-modes
d8e27b7 
Fixes helix-editor#10006
postsolar pushed a commit to postsolar/helix that referenced this issue Apr 4, 2024
@archseer @postsolar
Fix regression in color-modes
960ecdd 
Fixes helix-editor#10006
postsolar pushed a commit to postsolar/helix that referenced this issue Apr 4, 2024
@archseer @postsolar
Fix regression in color-modes
d54df95 
Fixes helix-editor#10006
postsolar pushed a commit to postsolar/helix that referenced this issue Apr 20, 2024
@archseer @postsolar
Fix regression in color-modes
ab8a9a7 
Fixes helix-editor#10006
mtoohey31 pushed a commit to mtoohey31/helix that referenced this issue Jun 2, 2024
@archseer @mtoohey31
Fix regression in color-modes
ba23aed 
Fixes helix-editor#10006
Vulpesx pushed a commit to Vulpesx/helix that referenced this issue Jun 7, 2024
@archseer @Vulpesx
Fix regression in color-modes
d3e99c4 
Fixes helix-editor#10006
smortime pushed a commit to smortime/helix that referenced this issue Jul 10, 2024
@archseer
Fix regression in color-modes
963ea98 
Fixes helix-editor#10006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ascarter @archseer