Center the picker preview selection using visual lines #7837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
previously approved these changes
Aug 5, 2023
There was a problem hiding this comment.
One small not, otherwise thus liims good. This was a good catch and something I missed in #5420
this way the preview always shows the selection even if lines were wrapped
|
fixed |
pascalkuthe
approved these changes
Aug 5, 2023
pascalkuthe
added
C-bug
the-mikedavis
approved these changes
Aug 8, 2023
the-mikedavis
changed the title
Merged
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
…7837) this way the preview always shows the selection even if lines were wrapped
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
…7837) this way the preview always shows the selection even if lines were wrapped
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
…7837) this way the preview always shows the selection even if lines were wrapped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this way the preview always shows the selection even if lines were wrapped
fixes #7836