Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global search preview doesn't correctly display the found line #7836

Closed
doy opened this issue Aug 5, 2023 · 0 comments · Fixed by #7837
Closed

global search preview doesn't correctly display the found line #7836

doy opened this issue Aug 5, 2023 · 0 comments · Fixed by #7837
Labels
C-bug Category: This is a bug

Comments

@doy
Copy link
Contributor

doy commented Aug 5, 2023

Summary

i believe this is an issue with soft wrapping - the line that the preview window puts at the top would be correct to center the selected line if lines were not wrapped, but if lines were wrapped, it pushes the selection down, eventually past the bottom of the preview window.

Reproduction Steps

if i do a global search for preview in the helix repository, a file that doesn't require line wrapping displays the found line properly centered:
preview1
but if the file has longer lines, the found line gets pushed downward:
preview2
sometimes off the visible area entirely:
preview3

Helix log

No response

Platform

linux

Terminal Emulator

alacritty 0.12.2

Helix Version

helix 23.05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant