fix windows build #6834
Merged
fix windows build #6834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
E-easy
dead10ck
reviewed
Apr 20, 2023
|
Apparently sr.ht has an ongoing DDoS and that is why it is down: https://codeberg.org/ddevault/pages/src/commit/678f15e04e01ee4420b6140ad333cb3f3d22d7bc/affected/git.sr.ht/index.html#L461 (also the reason the build is failing for anyone checking this pr) |
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6792 seems to have broken windows builds apparently
/std=c11and/std=c++14can not be used together after all even tough it did sound like that in the documentation. I added the same workaround we already had for unix. I don't have a local windows environment setup and relied on CI for testing but that used a cached build, because the actual grammars didn't change.I had to clear windows CI caches for #6808 which meant that CI is now failing on master even tough it passed for all PRs.