Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cargo update #6808

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Run cargo update #6808

merged 1 commit into from
Apr 20, 2023

Conversation

pascalkuthe
Copy link
Member

@pascalkuthe pascalkuthe commented Apr 18, 2023

Closes #6806

The windows v0.47.0 was yanked recently (apparently broke some builds but didn't affect us) so I ran cargo update to fix that. It seems that depandabot doesn't really update indirect dependencies with cargo update, so there are a bunch more updates here.

I have reviewed all commits in the dependencies to avoid supply chain attacks (although all these crates are published by people I trust). I extracted any changes that are interesting for helix

  • core-foundation-sys (macos): remove build script in favor of conditional link attribute (slightly faster build times)
  • syn: -
  • gix-hash / gix-hashtable: Fix bug where hashing an oid instead of an ObjectId caused a panic on 32bit systems. Doesn't affect helix currently but would have with future stuff I had planned.
  • gix-revision: correctly parse revisions that contain @. Doesn't affect helix currently but would have with future stuff I had planned.
  • filetime windows-sys bump
  • rustix: -
  • getrandom :
  • errno -
  • proc-macro2: -
  • windows: changes to the way files are build. Apparently this is more reliable but it did mean we had to clear build caches (CI failed otherwise)

@pascalkuthe pascalkuthe added E-easy Call for participation: Experience needed to fix: Easy / not much A-packaging Area: Packaging and bundling S-waiting-on-review Status: Awaiting review from a maintainer. labels Apr 18, 2023
@pascalkuthe
Copy link
Member Author

I had to change the build changes for windows to make the CI pass because the windows update changed something about the way they link to stuff I think. The error was very non-descript (documentation pretty much said "anything can cause this") but the Microsoft documentation suggested clearing caches so I did that and it worked :D

@archseer archseer merged commit b336cd7 into helix-editor:master Apr 20, 2023
@pascalkuthe pascalkuthe deleted the update_deps branch April 20, 2023 21:08
@pascalkuthe pascalkuthe mentioned this pull request Apr 20, 2023
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-packaging Area: Packaging and bundling E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
3 participants