Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(commands): add clear_registers command #5695

Merged
merged 1 commit into from
Apr 27, 2023
Merged

feat(commands): add clear_registers command #5695

merged 1 commit into from
Apr 27, 2023

Conversation

chorcheus
Copy link
Contributor

@chorcheus chorcheus commented Jan 26, 2023 •
edited
Loading

Closes #4256. This is a rework of closed #4408. Summary of discussion from there:

  • clear registers by pressing " and then the key to clear the registers
  • the key to clear the registers is suggested to be |

@chorcheus chorcheus mentioned this pull request Jan 26, 2023
Closed
@the-mikedavis
Copy link
Member

We could also consider not adding a keybinding for this. You would need to execute it through the command palette <space>? but I don't think that's a problem since this isn't something you need to do very often (if at all)

@the-mikedavis the-mikedavis added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Jan 26, 2023
@chorcheus chorcheus force-pushed the jrg-delete-registers branch 2 times, most recently from 76277a4 to 910de8f Compare January 30, 2023 19:18
@chorcheus
Copy link
Contributor Author

chorcheus commented Jan 30, 2023 •
edited
Loading

@the-mikedavis Thanks, I added the changes.

@chorcheus chorcheus force-pushed the jrg-delete-registers branch from 910de8f to 7f30e49 Compare January 31, 2023 07:07
@archseer
Copy link
Member

archseer commented Feb 1, 2023

This could be a typable command? :clear-register @

@chorcheus chorcheus force-pushed the jrg-delete-registers branch from 7f30e49 to fefa425 Compare February 4, 2023 13:15
the-mikedavis
the-mikedavis reviewed Feb 4, 2023
View reviewed changes
helix-term/src/commands.rs Outdated Show resolved Hide resolved
helix-term/src/commands/typed.rs Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis mentioned this pull request Feb 4, 2023
Open
@chorcheus chorcheus force-pushed the jrg-delete-registers branch 2 times, most recently from 799aebb to 1ff30f8 Compare February 4, 2023 22:16
@chorcheus chorcheus force-pushed the jrg-delete-registers branch 2 times, most recently from b5adc21 to 6d8d83b Compare February 12, 2023 19:55
@chorcheus chorcheus force-pushed the jrg-delete-registers branch from 6d8d83b to 345cae1 Compare February 25, 2023 16:35
dead10ck
dead10ck previously approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@dead10ck dead10ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me 👍

@chorcheus chorcheus force-pushed the jrg-delete-registers branch from 345cae1 to d015911 Compare April 8, 2023 07:51
@chorcheus
Copy link
Contributor Author

@the-mikedavis could you please look at this? Are you OK with the current implementation?

@pascalkuthe pascalkuthe merged commit 204d1eb into helix-editor:master Apr 27, 2023
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
@chorcheus @Triton171
feat(commands): add clear-register typable command (helix-editor#5695)
028ee18 
Co-authored-by: Jorge <[email protected]>
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@chorcheus @wes-adams
feat(commands): add clear-register typable command (helix-editor#5695)
02622a5 
Co-authored-by: Jorge <[email protected]>
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@chorcheus
feat(commands): add clear-register typable command (helix-editor#5695)
1859b00 
Co-authored-by: Jorge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudormrfbin sudormrfbin sudormrfbin left review comments

@pascalkuthe pascalkuthe pascalkuthe approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@dead10ck dead10ck dead10ck left review comments

Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete registers
6 participants
@chorcheus @the-mikedavis @archseer @dead10ck @sudormrfbin @pascalkuthe